Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29502][Filesystem][S3] Update the Hadoop implementation for filesystems to 3.3.4 #20955

Merged
merged 2 commits into from Oct 13, 2022

Conversation

MartijnVisser
Copy link
Contributor

What is the purpose of the change

  • Bump Hadoop dependencies for filesystems implementations

Brief change log

  • Updated POM
  • Updated NOTICE files

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: yes

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@MartijnVisser MartijnVisser self-assigned this Oct 4, 2022
@flinkbot
Copy link
Collaborator

flinkbot commented Oct 4, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@zentol
Copy link
Contributor

zentol commented Oct 5, 2022

	flink-s3-fs-hadoop:
		 These issue are legally problematic and MUST be fixed: 
			Dependency ch.qos.reload4j:reload4j:1.2.22 is not listed.
			Dependency org.slf4j:slf4j-reload4j:1.7.36 is not listed.
	flink-s3-fs-presto:
		 These issue are legally problematic and MUST be fixed: 
			Dependency ch.qos.reload4j:reload4j:1.2.22 is not listed.
			Dependency org.slf4j:slf4j-reload4j:1.7.36 is not listed.

@zentol zentol closed this Oct 5, 2022
@zentol zentol reopened this Oct 5, 2022
@MartijnVisser
Copy link
Contributor Author

@zentol Can you take a last look?

@zentol
Copy link
Contributor

zentol commented Oct 13, 2022

Can you clean up the commits to have 1 with the version bump + exclusions and 1 with the NOTICE sorting?

Ideally, first sort, then version bump.

@MartijnVisser
Copy link
Contributor Author

Ideally, first sort, then version bump.

@zentol Done

@zentol zentol merged commit 62e48fc into apache:master Oct 13, 2022
@MartijnVisser MartijnVisser deleted the lcm/hadoop-334 branch October 13, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants