Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29458][docs] When two tables have the same field, do not speci… #20983

Merged
merged 2 commits into from Oct 31, 2022

Conversation

ZmmBigdata
Copy link
Contributor

What is the purpose of the change

When two tables have the same field, do not specify the table name,Exception will be thrown:SqlValidatorException :Column 'currency' is ambiguous.

The page url is https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/dev/table/sql/queries/joins/

Brief change log

The table name is added before the query field,“ orders.currency”

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

…fy the table name,Exception will be thrown:SqlValidatorException :Column 'currency' is ambiguous
@flinkbot
Copy link
Collaborator

flinkbot commented Oct 8, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@lincoln-lil
Copy link
Contributor

@ZmmBigdata Thanks for fixing this! It's better to fix the chinese version (though it hasn't been translated yet) docs/content.zh/docs/dev/table/sql/queries/joins.md as well.

@ZmmBigdata
Copy link
Contributor Author

@ZmmBigdata Thanks for fixing this! It's better to fix the chinese version (though it hasn't been translated yet) docs/content.zh/docs/dev/table/sql/queries/joins.md as well.

@lincoln-lil Can you merge this first? I'll change the Chinese document,I want a contributor,hhh

…fy the table name,Exception will be thrown:SqlValidatorException :Column 'currency' is ambiguous
Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit 97fbb70 into apache:master Oct 31, 2022
yuzelin pushed a commit to yuzelin/flink that referenced this pull request Nov 1, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
dchristle pushed a commit to dchristle/flink that referenced this pull request Nov 18, 2022
akkinenivijay pushed a commit to krisnaru/flink that referenced this pull request Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants