Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29408][hive] fix HiveCatalogITCase fail with NPE #20999

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

luoyuxia
Copy link
Contributor

@luoyuxia luoyuxia commented Oct 10, 2022

What is the purpose of the change

To fix the HiveCatalogITCase fail with NPE

Brief change log

  • Changes statement load data inpath to statement load data local inpath in HiveDialectQueryITCase for load data inpath will move /csv/test.csv, which will result in other test can't find the file /csv/test.csv.

Verifying this change

The pr #20905.
Without this commit, the misc test will failure https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=41778&view=results.
With this commit, the misc test will pass again https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=41820&view=results.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 10, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@zentol
Copy link
Contributor

zentol commented Oct 10, 2022

How does this fix a class-loading NPE in another test?

@zentol zentol self-assigned this Oct 10, 2022
@luoyuxia
Copy link
Contributor Author

The load data inpath statement in HiveDialectQueryITCase will move /csv/test.csv to other place, then other tests will get null by getClass().getResource("/csv/test.csv").
So I change it to statement load local data inpath, which will copy /csv/test.csv.

@zentol
Copy link
Contributor

zentol commented Oct 11, 2022

I see, thanks for the explanation.

That must've been difficult to figure out; good job 👍

@zentol zentol merged commit 23e0272 into apache:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants