Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-28049][connectors] Introduce FLIP-208 functionality to stop So… #21014

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kamronis
Copy link

…urce based on consumed records. Add interfaces for Kafka and Pulsar sources.

What is the purpose of the change

This pull request provides interface for creating RecordEvalutor classes to stop source based on consumed records. Added functionality works for Kafka and Pulsar sources.

Brief change log

  • Added RecordEvalutor interface
  • Added SourceOutPutWrapper to
  • Modified SourceReaderBase and SingleThreadMultiplexSourceReaderBase to work with evaluator
  • Added setEofRecordEvaluator methods for Kafka and Pulsar connectors

Verifying this change

This change added tests and can be verified as follows:

(example:)

  • Added tests to validate stopping of the job when number element is reached

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (yes)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (don't know)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)

…urce based on consumed records. Add interfaces for Kafka and Pulsar sources.
@flinkbot
Copy link
Collaborator

flinkbot commented Oct 11, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@MartijnVisser
Copy link
Contributor

@kamronis Thanks for the PR, but no vote has happened on FLIP-208 so it can't be merged and hence a review also doesn't really make sense yet

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First get the FLIP accepted, then let's review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants