-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-29501] Add option to override job vertex parallelisms during job submission #21023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've removed the dependency on #21008. |
mxm
force-pushed
the
FLINK-29501
branch
2 times, most recently
from
November 11, 2022 16:45
fbc0fca
to
04c9ed8
Compare
…ob submission This allows to change the job vertex parallelism of a JobGraph during job submission time without having to modify the JobGraph upfront. The initial idea was to add a new field to the payload of the job submit Rest endpoint. However, it is probably more practical to handle the overrides in the same way as other PipelineOptions already do it, i.e. via the configuration. The implementation is deliberately lenient with respect to the presence of job vertices. If vertices have been removed or new ones have been added, only the ones found will have their parallelism overrides. The verification should be performed by the caller, not by Flink. In particular, we want to support scenarios where users modify the deployment and we might not yet have overrides for all vertices.
@flinkbot run azure |
gyfora
approved these changes
Nov 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Seems like the doc need to be regenerated:
|
@flinkbot run azure |
akkinenivijay
pushed a commit
to krisnaru/flink
that referenced
this pull request
Feb 11, 2023
…ob submission (apache#21023) This allows to change the job vertex parallelism of a JobGraph during job submission time without having to modify the JobGraph upfront. This is intended to be used for (auto)scaling Flink jobs based on metric observations. The initial idea was to add a new field to the payload of the job submit Rest endpoint. However, it is probably more practical to handle the overrides in the same way as other PipelineOptions already do it, i.e. via the configuration. The implementation is deliberately lenient with respect to the presence of job vertices. If vertices have been removed or new ones have been added, only the ones found will have their parallelism overrides. The verification should be performed by the caller, not by Flink. In particular, we want to support scenarios where users modify the deployment and we might not yet have overrides for all vertices.
vaibhav-gosain-glean
pushed a commit
to vaibhav-gosain-glean/flink
that referenced
this pull request
Aug 21, 2023
…ob submission (apache#21023) This allows to change the job vertex parallelism of a JobGraph during job submission time without having to modify the JobGraph upfront. This is intended to be used for (auto)scaling Flink jobs based on metric observations. The initial idea was to add a new field to the payload of the job submit Rest endpoint. However, it is probably more practical to handle the overrides in the same way as other PipelineOptions already do it, i.e. via the configuration. The implementation is deliberately lenient with respect to the presence of job vertices. If vertices have been removed or new ones have been added, only the ones found will have their parallelism overrides. The verification should be performed by the caller, not by Flink. In particular, we want to support scenarios where users modify the deployment and we might not yet have overrides for all vertices. (cherry picked from commit 23ce228)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This allows to change the job vertex parallelism of a JobGraph during job submission time without having to modify the JobGraph upfront. This is intended to be used for (auto)scaling Flink jobs based on metric observations.
The initial idea was to add a new field to the payload of the job submit Rest endpoint. However, it is probably more practical to handle the overrides in the same way as other PipelineOptions already do it, i.e. via the configuration.
The implementation is deliberately lenient with respect to the presence of job vertices. If vertices have been removed or new ones have been added, only the ones found will have their parallelism overrides. The verification should be performed by the caller, not by Flink. In particular, we want to support scenarios where users modify the deployment and we might not yet have overrides for all vertices.
Based on feedback in #20953.
Brief change log
Verifying this change
Tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation