Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29751][sql-client] Implement a new ClientResult for sql client to wrap the result returned by sql gateway #21040

Closed
wants to merge 1 commit into from

Conversation

yuzelin
Copy link
Contributor

@yuzelin yuzelin commented Oct 13, 2022

What is the purpose of the change

The result returned by sql gateway is ResultSet but the current ResultStore accepts a TableResult. So we introduce a ClientResult to wrap it.

Brief change log

  • implement ClientResult.

Verifying this change

This change is a component of further feature, I will add tests later.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? JavaDoc

@yuzelin yuzelin changed the title [FLINK-29486][sql-client] Implement a new ClientResult for Sql [FLINK-29486][sql-client] Implement a new ClientResult for sql client to wrap the result returned by sql gateway Oct 13, 2022
@flinkbot
Copy link
Collaborator

flinkbot commented Oct 13, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@yuzelin yuzelin force-pushed the UnifyExecutor branch 5 times, most recently from f1c2f60 to 68d40b9 Compare October 25, 2022 04:14
@yuzelin yuzelin closed this Oct 27, 2022
@yuzelin yuzelin deleted the UnifyExecutor branch October 27, 2022 04:07
@yuzelin yuzelin restored the UnifyExecutor branch October 27, 2022 09:26
@yuzelin yuzelin reopened this Oct 27, 2022
@yuzelin yuzelin closed this Oct 27, 2022
@yuzelin yuzelin deleted the UnifyExecutor branch October 27, 2022 09:27
@yuzelin yuzelin restored the UnifyExecutor branch October 27, 2022 09:32
@yuzelin yuzelin reopened this Oct 27, 2022
@yuzelin yuzelin changed the title [FLINK-29486][sql-client] Implement a new ClientResult for sql client to wrap the result returned by sql gateway [FLINK-][sql-client] Implement a new ClientResult for sql client to wrap the result returned by sql gateway Oct 27, 2022
@yuzelin yuzelin changed the title [FLINK-][sql-client] Implement a new ClientResult for sql client to wrap the result returned by sql gateway [FLINK-29751][sql-client] Implement a new ClientResult for sql client to wrap the result returned by sql gateway Nov 9, 2022
@yuzelin yuzelin closed this Jan 17, 2023
@yuzelin yuzelin deleted the UnifyExecutor branch March 16, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants