Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29638][connectors][filesystems][formats] Update Jackson-BOM to 2.13.4.2 because of CVE-2022-42003 #21064

Merged
merged 1 commit into from Oct 19, 2022

Conversation

snuyanzin
Copy link
Contributor

What is the purpose of the change

Update multiple Jackson dependencies to 2.13.4.2 to fix CVE-2022-42003

Brief change log

  • Updated POM file

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes )
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no )
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable )

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 14, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin snuyanzin changed the title [FLINK-29638][connectors][filesystems][formats] Update Jackson-BOM to 2.13.4.2 [FLINK-29638][connectors][filesystems][formats] Update Jackson-BOM to 2.13.4.2 because of CVE-2022-42003 Oct 14, 2022
@snuyanzin
Copy link
Contributor Author

@flinkbot run azure

failure seems related to https://issues.apache.org/jira/browse/FLINK-29387

@MartijnVisser MartijnVisser self-assigned this Oct 18, 2022
Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Thanks @snuyanzin for looking after this. 👍

I verified that the bom upgrade really only touched jackson-databind (see FasterXML/jackson-bom@e58163a) through

$ mvn dependency:tree -Dincludes="*jackson*"
[INFO] Scanning for projects...
[INFO] 
[INFO] -----------------< org.apache.flink:flink-kubernetes >------------------
[INFO] Building Flink : Kubernetes 1.17-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:3.2.0:tree (default-cli) @ flink-kubernetes ---
[INFO] org.apache.flink:flink-kubernetes:jar:1.17-SNAPSHOT
[INFO] \- io.fabric8:kubernetes-client:jar:5.12.3:compile
[INFO]    +- io.fabric8:kubernetes-model-core:jar:5.12.3:compile
[INFO]    |  \- com.fasterxml.jackson.core:jackson-annotations:jar:2.13.4:compile
[INFO]    +- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.13.4:compile
[INFO]    +- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.13.4:compile
[INFO]    +- com.fasterxml.jackson.core:jackson-databind:jar:2.13.4.2:compile
[INFO]    \- com.fasterxml.jackson.core:jackson-core:jar:2.13.4:compile
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.019 s
[INFO] Finished at: 2022-10-19T09:04:35+02:00
[INFO] ------------------------------------------------------------------------

All relevant occurrences in NOTICE files have been touched according to my checks. Please provide backports for 1.16 and 1.15

@XComp
Copy link
Contributor

XComp commented Oct 19, 2022

I created backports for 1.16 (and 1.15) to speed things up and to make the change more likely to go into 1.16.0. Please have a look at the PRs, @snuyanzin

@XComp XComp merged commit bee3e94 into apache:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants