[FLINK-29622][runtime][security] Start kerberos delegation token prov… #21114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ider only if the user provided valid credentials
zentol
reviewed
Oct 19, 2022
Comment on lines
+49
to
+51
| KerberosLoginProvider kerberosLoginProvider = | ||
| new KerberosLoginProvider(configuration); | ||
| if (kerberosLoginProvider.isLoginPossible()) { |
There was a problem hiding this comment.
its a bit strange that we create a provider, use it for one call, throw it away, only for it to be re-created in the delegation token manager.
There was a problem hiding this comment.
Having a static function which is hardly testable would be more strange. From perf perspective this runs once per cluster start.
|
Thanks for taking a look, @zentol. Based on the urgency of the matter and @gaborgsomogyi's reply I am comfortable with merging this as soon as the CI passes. I have performed local tests which look good. Let me know if you have further input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #21098 that I have already merged to master.
cc @gaborgsomogyi