[FLINK-29742][sql-gateway] Support completing statement in SqlGatewayService. #21141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzelin
changed the title
|
@flinkbot run azure |
1 similar comment
|
@flinkbot run azure |
|
cc @fsk119 |
jnh5y
approved these changes
Nov 14, 2022
fsk119
reviewed
Nov 24, 2022
...-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java
Outdated
Show resolved
Hide resolved
yuzelin
force-pushed
the
completeStatement
branch
6 times, most recently
from
04d96e1
to
fdfa3ce
Compare
yuzelin
force-pushed
the
completeStatement
branch
from
fdfa3ce
to
16a3d26
Compare
fsk119
reviewed
Dec 9, 2022
| Arrays.asList( | ||
| "default_catalog.default_database.Table1", | ||
| "default_catalog.default_database.Table2"); | ||
| String incompleteSql = "SELECT * FROM Ta"; |
There was a problem hiding this comment.
I think we can inline incompleteSql and expectedTableHints.
chucheng92
pushed a commit
to chucheng92/flink
that referenced
this pull request
Feb 3, 2023
…Service This closes apache#21141
akkinenivijay
pushed a commit
to krisnaru/flink
that referenced
this pull request
Feb 11, 2023
…Service This closes apache#21141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Implement
SqlGatewayService#completeStatementdescribed in FLIP-91.Brief change log
(for example:)
SqlGatewayService#completeStatement.testCompleteStatementinSqlGatewayServiceITCase.Verifying this change
This change added tests and can be verified as follows:
testCompleteStatementinSqlGatewayServiceITCase.Does this pull request potentially affect one of the following parts:
@Public(Evolving): yesDocumentation