[FLINK-30056][connectors][kafka] Replace deprecated kafka-clients methods #21150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flinkbot run azure |
snuyanzin
force-pushed
the
kafka_clients
branch
from
123bdae
to
2587493
Compare
snuyanzin
changed the title
|
@flinkbot run azure |
6 similar comments
|
@flinkbot run azure |
|
@flinkbot run azure |
|
@flinkbot run azure |
|
@flinkbot run azure |
|
@flinkbot run azure |
|
@flinkbot run azure |
snuyanzin
force-pushed
the
kafka_clients
branch
from
2587493
to
4c3b6c7
Compare
|
@flinkbot run azure |
zentol
requested changes
Nov 15, 2022
Comment on lines
-261
to
+262
| records = consumer.poll(pollTimeout); | ||
| records = consumer.poll(Duration.ofMillis(pollTimeout)); |
There was a problem hiding this comment.
Note: This changes the blocking behavior of this call.
I'd like to see a proper ticket for this particular change.
There was a problem hiding this comment.
yes, sure
jira issue created https://issues.apache.org/jira/browse/FLINK-30056
There was a problem hiding this comment.
please let me know if i need to change commit message or rebase
There was a problem hiding this comment.
Please split the commits such that 1 is making the poll change, and the other (hotfix) commit with the remaining changes.
snuyanzin
changed the title
snuyanzin
force-pushed
the
kafka_clients
branch
2 times, most recently
from
22e4694
to
47d13be
Compare
This changes the blocking behavior, as the previous method essentially ignored the timeout.
zentol
force-pushed
the
kafka_clients
branch
from
47d13be
to
e9459d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is replacing deprecated methods
org.apache.kafka.clients.admin.DescribeTopicsResult#all()
org.apache.kafka.clients.consumer.KafkaConsumer#poll(long)
as it was mentioned in corresponding javadocs
What is the purpose of the change
org.apache.kafka.clients.admin.DescribeTopicsResult#all() was made deprecated at https://issues.apache.org/jira/browse/KAFKA-10774
and it is suggested to use org.apache.kafka.clients.admin.DescribeTopicsResult#allTopicNames
org.apache.kafka.clients.consumer.KafkaConsumer#poll(long) was deprecated at https://issues.apache.org/jira/browse/KAFKA-5697
and it's suggested to use org.apache.kafka.clients.consumer.KafkaConsumer#poll(java.time.Duration)
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation