Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Add the final and fix typo #21193

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

1996fanrui
Copy link
Member

@1996fanrui 1996fanrui commented Oct 29, 2022

What is the purpose of the change

Add the final and fix typo

Brief change log

  • commit1: Add the final and fix typo
  • commit2: Remove the deprecated alignmentTimeout
  • commit3: Remove the deprecated method
  • commit4: Use method reference instead of inline lambda

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not documented

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 29, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@1996fanrui 1996fanrui force-pushed the hotfix/add-final-and-fix-typo branch 2 times, most recently from af712c4 to 7e613fe Compare November 12, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants