New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-29788][state] Disable changelog temporally when SnapshotMigrationTestBase triggers native savepoint #21196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionTestBase triggers native savepoint
masteryhx
force-pushed
the
FLINK-29788
branch
from
October 31, 2022 06:20
72aee69
to
6097154
Compare
@HuangXingBo Could you also help to take a look ? |
HuangXingBo
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masteryhx Thanks a lot for the fix. LGTM
HuangXingBo
pushed a commit
that referenced
this pull request
Oct 31, 2022
…ionTestBase triggers native savepoint This closes #21196.
yuzelin
pushed a commit
to yuzelin/flink
that referenced
this pull request
Nov 1, 2022
…ionTestBase triggers native savepoint This closes apache#21196.
huangxiaofeng10047
pushed a commit
to huangxiaofeng10047/flink
that referenced
this pull request
Nov 3, 2022
…ionTestBase triggers native savepoint This closes apache#21196.
dchristle
pushed a commit
to dchristle/flink
that referenced
this pull request
Nov 18, 2022
…ionTestBase triggers native savepoint This closes apache#21196.
sergeitsar
pushed a commit
to fentik/flink
that referenced
this pull request
Feb 8, 2023
…ionTestBase triggers native savepoint This closes apache#21196.
sergeitsar
pushed a commit
to fentik/flink
that referenced
this pull request
Feb 8, 2023
…ionTestBase triggers native savepoint This closes apache#21196.
akkinenivijay
pushed a commit
to krisnaru/flink
that referenced
this pull request
Feb 11, 2023
…ionTestBase triggers native savepoint This closes apache#21196.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
ChangelogStateBackend doesn't support native savepoint currently which is known, so we just disable changelog temporally when SnapshotMigrationTestBase triggers native savepoint
Brief change log
Verifying this change
This change is already covered by existing tests, such as TypeSerializerSnapshotMigrationITCase/StatefulJobWBroadcastStateMigrationITCase.
(need to modify FlinkVersion and ExecutionMode which will be modified by release manager later).
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation