Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29788][state] Disable changelog temporally when SnapshotMigrationTestBase triggers native savepoint #21196

Closed
wants to merge 1 commit into from

Conversation

masteryhx
Copy link
Contributor

What is the purpose of the change

ChangelogStateBackend doesn't support native savepoint currently which is known, so we just disable changelog temporally when SnapshotMigrationTestBase triggers native savepoint

Brief change log

  • Make SnapshotMigrationTestBase#executeAndSnapshot disbale changelog when triggering native savepoint.

Verifying this change

This change is already covered by existing tests, such as TypeSerializerSnapshotMigrationITCase/StatefulJobWBroadcastStateMigrationITCase.
(need to modify FlinkVersion and ExecutionMode which will be modified by release manager later).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

@masteryhx
Copy link
Contributor Author

@klion26 @Myasuka Could you help to take a look ?

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 31, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@masteryhx
Copy link
Contributor Author

@HuangXingBo Could you also help to take a look ?

Copy link
Contributor

@HuangXingBo HuangXingBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masteryhx Thanks a lot for the fix. LGTM

HuangXingBo pushed a commit that referenced this pull request Oct 31, 2022
…ionTestBase triggers native savepoint

This closes #21196.
yuzelin pushed a commit to yuzelin/flink that referenced this pull request Nov 1, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
dchristle pushed a commit to dchristle/flink that referenced this pull request Nov 18, 2022
sergeitsar pushed a commit to fentik/flink that referenced this pull request Feb 8, 2023
sergeitsar pushed a commit to fentik/flink that referenced this pull request Feb 8, 2023
akkinenivijay pushed a commit to krisnaru/flink that referenced this pull request Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants