Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29653][sql-client]Change ResultStore as [sessionId, [resultId, result]]. #21212

Open
wants to merge 1 commit into
base: release-1.15
Choose a base branch
from

Conversation

CallMeSurprise
Copy link

What is the purpose of the change

This pull request constructs result in ResultStore in format of [sessionId, [resultId, result]].

Brief change log

  • Construct results in ResultStore.java as [sessionId, [resultId, result]].
  • Add new variable sessionId in ResultDescriptor.java
  • Get and put result into ResultStore through param sessionId and resultId, if sessionId is empty, empty string will be default value.
  • Mark some methods without sessionId as deprecated and do not delete them. Maybe remove them later in a new flink version.

Verifying this change

This change is already covered by existing tests, such as CliClientTest/CliResultViewTest/CliTableauResultViewTest/TestingExecutor/LocalExecutorITCase.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 1, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants