Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-29812][rest] Remove deprecated Netty API usages #21215

Merged
merged 4 commits into from Nov 2, 2022
Merged

[FLINK-29812][rest] Remove deprecated Netty API usages #21215

merged 4 commits into from Nov 2, 2022

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Nov 1, 2022

No description provided.

@zentol zentol requested a review from XComp November 1, 2022 12:17
@flinkbot
Copy link
Collaborator

flinkbot commented Nov 1, 2022 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

XComp
XComp requested changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more occurrences of deprecated methods, e.g. in NettyConnectionManagerTest and WebFrontendBootstrap we use the deprecated .group() method. HttpTestClient uses .getMethod() in the flink-runtime-web module. I didn't continue looking for all occurrences.

@zentol
Copy link
Contributor Author

zentol commented Nov 1, 2022

@XComp Should be covering everything now.

@XComp
Copy link
Contributor

XComp commented Nov 1, 2022

HttpHeaderNames.Values is still used in HttpTestClient

@zentol
Copy link
Contributor Author

zentol commented Nov 1, 2022

HttpHeaderNames.Values is still used in HttpTestClient

FFS, IntelliJ's deprecation inspection is hot garbage.

XComp
XComp approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure of how much value the JavaDoc itself is but there is still code in the docs referring to the deprecated API in HttpTestClient:129-130.

Other than that, it looks good to me under the assumption that CI passes.

@zentol zentol merged commit 03c0f15 into apache:master Nov 2, 2022
@zentol zentol deleted the 29812 branch November 2, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XComp XComp XComp approved these changes

Assignees
No one assigned
Labels
component=Runtime/REST
Projects
None yet
Milestone
No milestone
3 participants
@zentol @flinkbot @XComp