Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29610] [flink-runtime]: Use ASK_TIMEOUT_DURATION instead of RpcUtils.INF_TIMEOUT in SavepointHandlers and CheckpointTriggerHandler #21239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leletan
Copy link
Contributor

@leletan leletan commented Nov 4, 2022

What is the purpose of the change

This pull request makes SavepointHandlers and CheckpointHandlers call to RestfulGateway using ASK_TIMEOUT_DURATION, instead of RpcUtils.INF_TIMEOUT

Brief change log

Use ASK_TIMEOUT_DURATION instead of RpcUtils.INF_TIMEOUT Infinite timeout in SavepointHandlers and CheckpointTriggerHandler

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

…TIMEOUT for savepoint and checkpoint trigger call to dispatcher
@flinkbot
Copy link
Collaborator

flinkbot commented Nov 4, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants