Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29952][table-api]Append the detail of the exception when drop tamporary table. #21268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

houhang1005
Copy link

Append the detail of the exception when drop tamporary table.

Signed-off-by: houhang houhang@asiainfo.com

What is the purpose of the change

Make the exception more clear when failed to drop a temporary table in sql-client.

Brief change log

  • Append a reason for the failure about dropping a temporary to current ValidationException.

Verifying this change

This change added tests and can be verified as follows:

  • Project can build successfully.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 9, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@houhang1005
Copy link
Author

@flinkbot run azure

@houhang1005
Copy link
Author

@flinkbot run azure

@houhang1005
Copy link
Author

@flinkbot run azure

1 similar comment
@houhang1005
Copy link
Author

@flinkbot run azure

…tamporary table, including Tests.

Signed-off-by: houhang <houhang@asiainfo.com>
@houhang1005
Copy link
Author

@flinkbot run azure

1 similar comment
@houhang1005
Copy link
Author

@flinkbot run azure

@fsk119 fsk119 self-requested a review November 17, 2022 03:23
@houhang1005
Copy link
Author

@fsk119 Hi! This is my first time to deal with a Flink PR, I don't know whether I missed any procedure. Please give me a little tip when you get free time -.-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants