New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-29452] Allow unit tests to be executed independently #21289
[FLINK-29452] Allow unit tests to be executed independently #21289
Conversation
...-utils-junit/src/test/java/org/apache/flink/testutils/junit/RetryOnFailureExtensionTest.java
Show resolved
Hide resolved
dfc9311
to
7833f1e
Compare
Hello! I've rebased this PR to master. I don't believe there are any remaining requested changes that I haven't addressed (by comment or other). I will be mostly away from my computer for a couple of weeks, but I'll check in if anything changes! |
7833f1e
to
4ec0ed5
Compare
...tils-junit/src/test/java/org/apache/flink/testutils/junit/RetryOnExceptionExtensionTest.java
Outdated
Show resolved
Hide resolved
...-utils-junit/src/test/java/org/apache/flink/testutils/junit/RetryOnFailureExtensionTest.java
Outdated
Show resolved
Hide resolved
OK, change applied, thanks for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR. There are still some plain text method names in the test code which we could get rid off.
Additionally, can you reorganize/squash the commits and rebase the branch to prepare the final CI run?
...tils-junit/src/test/java/org/apache/flink/testutils/junit/RetryOnExceptionExtensionTest.java
Outdated
Show resolved
Hide resolved
...tils-junit/src/test/java/org/apache/flink/testutils/junit/RetryOnExceptionExtensionTest.java
Outdated
Show resolved
Hide resolved
...tils-junit/src/test/java/org/apache/flink/testutils/junit/RetryOnExceptionExtensionTest.java
Outdated
Show resolved
Hide resolved
...-utils-junit/src/test/java/org/apache/flink/testutils/junit/RetryOnFailureExtensionTest.java
Outdated
Show resolved
Hide resolved
...-utils-junit/src/test/java/org/apache/flink/testutils/junit/RetryOnFailureExtensionTest.java
Outdated
Show resolved
Hide resolved
...tils-junit/src/test/java/org/apache/flink/testutils/junit/RetryOnExceptionExtensionTest.java
Outdated
Show resolved
Hide resolved
e982964
to
f980618
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for addressing my comments. Please squash the commits into reasonable chunks to prepare the PR merge.
[hotfix] Add missing space padding for test retry message [FLINK-29452][test] Refactor for helper methods from review Apply suggestions from code review Co-authored-by: Matthias Pohl <matthias.pohl@aiven.io> Change private HashMap<> to interface
f980618
to
bd29f34
Compare
Rebased and squashed! |
What is the purpose of the change
This is a minor clean up of the unit tests that check the functionality of
@RetryOnFailure
and@RetryOnException
. Currently, executing a single test method will fail; all unit tests in these two classes need to be executed in order for any to pass.Brief change log
@AfterAll
verification.@BeforeEach
andTestInfo
from JUnit5), and verify the counts only if they exist in the@AfterAll
NUMBER_OF_RUNS
toNUMBER_OF_RETRIES
which is a bit clearer.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
One way to check this manually is to run any single test in isolation:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation