[FLINK-4087] [metrics] Improved JMX port handling #2145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.reporter = new JMXReporter(); | ||
| this.reporter.open(reporterConfig); |
There was a problem hiding this comment.
There is also the catch clause of the else branch where we create a JMXReporter, but we never call the open method there. I think we should add a proper open call there as well.
|
Good work @zentol. I mostly had general questions for my understanding. Before merging, I think it would be good to add a JMXReporter test which checks that we can start multiple JMXReporter on the same machine and that we can query them. |
-refactor JMXReporter start into separate method -removed all jmx-related JVM arguments -use NetUtils.getPortRangeFromString -refactored JMXServer to be instantiated once
|
@tillrohrmann I've addressed your comments. |
|
Excellent @zentol :-) +1 for merging. |
|
merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the JMX port handling.
Instead of setting a specific configured port on JVM start-up we use an ephemeral port for the JVM's JMXServer.
Inside the JVM we then spin-up another JMXServer which users can connect to. This JMXServer picks a port from a configured port range; iterating from start to end until it finds an open one.