Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-30517][log]Decrease log output interval while waiting for YARN… #21569

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

huwh
Copy link
Contributor

@huwh huwh commented Dec 28, 2022

… JobManager be allocated.

What is the purpose of the change

Flink Client will retrieve the application status every 250ms after submitting to YARN.
If JobManager does not start in 60 seconds, it will log "Deployment took more than 60 seconds. Please check if the requested resources are available in the YARN cluster" every 250ms. This will lead to too many logs.

We can keep the check interval at 250ms, but log the message every 1 minute.

Brief change log

  • Decrease log output interval while waiting for YARN JobManager be allocated

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 28, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@huwh
Copy link
Contributor Author

huwh commented Feb 21, 2023

@xintongsong Hi, Could you help take a look at this?

Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huwh, LGTM.

@reswqa reswqa merged commit 1993ad0 into apache:master Mar 2, 2023
@huwh huwh deleted the decreaseLogInterval branch March 8, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants