Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-30558][runtime] Use different metric object to avoid metric 'numRestarts' being overridden by 'fullRestarts' in SchedulerBase #21598

Merged
merged 1 commit into from Jan 5, 2023

Conversation

SinBex
Copy link
Contributor

@SinBex SinBex commented Jan 4, 2023

What is the purpose of the change

Fix metric override each other. The method SchedulerBase#registerJobMetrics register metrics 'numRestarts' and 'fullRestarts' with the same metric object, which will result in the loss of the metric 'numRestarts'.

Brief change log

avoid metric 'numRestarts' being overridden by 'fullRestarts'

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…umRestarts' being overridden by 'fullRestarts' in SchedulerBase
@SinBex SinBex changed the title [FLINK-30558][runtime] use different metric object to avoid metric 'numRestarts' being overridden by 'fullRestarts' in SchedulerBase [FLINK-30558][runtime] Use different metric object to avoid metric 'numRestarts' being overridden by 'fullRestarts' in SchedulerBase Jan 4, 2023
@flinkbot
Copy link
Collaborator

flinkbot commented Jan 4, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR! @SinBex
LGTM.

@zhuzhurk zhuzhurk merged commit b50f426 into apache:master Jan 5, 2023
zhuzhurk pushed a commit that referenced this pull request Jan 5, 2023
…umRestarts' being overridden by 'fullRestarts' in SchedulerBase

This closes #21598.
sergeitsar pushed a commit to fentik/flink that referenced this pull request Feb 8, 2023
…umRestarts' being overridden by 'fullRestarts' in SchedulerBase

This closes apache#21598.
sergeitsar pushed a commit to fentik/flink that referenced this pull request Feb 8, 2023
…umRestarts' being overridden by 'fullRestarts' in SchedulerBase

This closes apache#21598.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants