Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-30557][connector/kinesis] Remove Kinesis Data Streams connecto… #21600

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

dannycranmer
Copy link
Contributor

…rs from Flink master branch

What is the purpose of the change

Remove the Amazon Kinesis Data Streams connectors from the Flink master branch now they have been externalized to https://github.com/apache/flink-connector-aws

Brief change log

  • Delete:
    • flink-connector-kinesis
    • flink-connector-aws-kinesis-streams
    • flink-sql-connector-kinesis
    • flink-sql-connector-aws-kinesis-streams
  • Delete e2e tests
  • Update GSR format e2e tests to use 1.16.0 Kinesis connector until it is externalized.

Verifying this change

This change is mostly a trivial rework / code cleanup without any test coverage.
Verified flink-glue-schema-registry-[avro|json]-test using mvn clean install -Prun-end-to-end-tests (providing AWS keys)

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 4, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@dannycranmer
Copy link
Contributor Author

@flinkbot run azure

1 similar comment
@dannycranmer
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@hlteoh37 hlteoh37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified that covered the following:

  • Removed source code for Kinesis connector
  • Removed Kinesis connector E2E tests
  • Python connectors point to the externalized connector
  • Docs point to externalized connector (in different PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants