[FLINK-4121] Add timeunit (ms) to docs for timestamps and watermarks #2165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR inserts an explicit specification of the timeunit used in watermarks and timestamps in the documentation. (According to FLINK-4121).
I'm teaching a class where students are supposed to implement Flink streaming programs. It seems to be unclear for them, that the time unit of timestamps and watermarks is milliseconds. They just see TimeWindow.seconds(...) or something similar and assume the timestamps to be of the same unit (seconds) which is obviously not the case. I just checked the documentation and there is no explicit specification of the time unit used for timestamps. After short talk with Aljoscha Krettek, I'll open a mini-PR to address this issue.
@aljoscha Please let me know in case you need anything else to merge this.