Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-4121] Add timeunit (ms) to docs for timestamps and watermarks #2165

Closed
wants to merge 1 commit into from

Conversation

powibol
Copy link
Contributor

@powibol powibol commented Jun 27, 2016

This PR inserts an explicit specification of the timeunit used in watermarks and timestamps in the documentation. (According to FLINK-4121).

I'm teaching a class where students are supposed to implement Flink streaming programs. It seems to be unclear for them, that the time unit of timestamps and watermarks is milliseconds. They just see TimeWindow.seconds(...) or something similar and assume the timestamps to be of the same unit (seconds) which is obviously not the case. I just checked the documentation and there is no explicit specification of the time unit used for timestamps. After short talk with Aljoscha Krettek, I'll open a mini-PR to address this issue.

@aljoscha Please let me know in case you need anything else to merge this.

@aljoscha
Copy link
Contributor

I think it would be better to only have one place in the doc where we say that timestamps/watermarks are in milliseconds (with a red warning box, so it's visible). I can change it while merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants