New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-30257] fix SqlClientITCase#testMatchRecognize #21696
Conversation
int numberOfResultRecords = UpsertTestFileUtil.getNumberOfRecords(tempOutputFile); | ||
int numberOfResultRecords; | ||
while (true) { | ||
Thread.sleep(5000); // prevent NotFoundException: Status 404 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zentol Any thoughts if/how we could get rid of the wait?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @zentol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the end of the way you will need to poll something, be it for the output file or the status of the job.
But the sleep could be way lower; 50ms would be perfectly fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WencongLiu Could you lower the sleep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. thx @MartijnVisser @zentol
c4b7c8b
to
f981dd0
Compare
f981dd0
to
0fd04af
Compare
@WencongLiu You'll need to rebase your PR with the latest changes from |
@flinkbot run azure |
0fd04af
to
6948b09
Compare
6948b09
to
72bd4cc
Compare
@zentol @MartijnVisser Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WencongLiu Thanks! Will you also create backports to release-1.17
and potentially release-1.16
?
Do you mean to create the same pull request for |
What is the purpose of the change
fix SqlClientITCase#testMatchRecognize
Brief change log
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation