[FLINK-30812][yarn] Fix uploading local files when using YARN with S3 #21788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartijnVisser
requested changes
Jan 30, 2023
flink-yarn/src/test/java/org/apache/flink/yarn/YarnApplicationFileUploaderTest.java
Outdated
Show resolved
Hide resolved
|
@gaborgsomogyi Can you take a look? |
|
I'm having vacation on the whole week w/o computer. Next week I can start w/ this... |
| @@ -388,13 +388,20 @@ private Path copyToRemoteApplicationDir( | |||
| (relativeDstPath.isEmpty() ? "" : relativeDstPath + "/") + localSrcPath.getName(); | |||
| final Path dst = new Path(applicationDir, suffix); | |||
|
|
|||
| final Path localSrcPathWithScheme; | |||
| if (localSrcPath.toUri().getScheme() == null) { | |||
There was a problem hiding this comment.
Not sure about the internal details of the Uri parsing but isNullOrWhitespaceOnly sounds more safe.
There was a problem hiding this comment.
Thank you, I agree, I've changed it
gaborgsomogyi
approved these changes
Jul 31, 2023
|
Rebased to fix failing CI tests |
|
@MartijnVisser are you fine w/ the PR? I'm merging if you say so... |
|
Waiting to end the feature freeze.... |
|
@flinkbot run azure |
|
Unless there are objections + azure is passing I'm intended to merge this tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Hadoop versions starting from 3.3.2 have reworked copying local files to remote using S3AFileSystem. Now it requires the passed local Hadoop Path to have a
schemespecified.Brief change log
YarnApplicationFileUploader will append
file://scheme for local path if none specifiedVerifying this change
I manually tested on a local single-node Hadoop 3.3.4 cluster with
fs.defaultFSpointing to a local Minio S3 server. Creating a Flink YARN session failed before the fix, but worked after.Also added new unit test in
YarnApplicationFileUploaderTest.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no) noDocumentation