[FLINK-30840][sql-client] Fix resource leak when creating Executor #21800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsk119
force-pushed
the
fix-leak
branch
2 times, most recently
from
a3f5573
to
cc9ff5a
Compare
lincoln-lil
reviewed
Feb 2, 2023
There was a problem hiding this comment.
@fsk119 thanks for fixing this! Can use such as 'AutoCloseableRegistry' to unify the release of various resources？If do so, we may easier to handle multiple resources and exception messages
...table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ExecutorImpl.java
Outdated
Show resolved
Hide resolved
...table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ExecutorImpl.java
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/SqlClient.java
Show resolved
Hide resolved
lincoln-lil
approved these changes
Feb 2, 2023
| try { | ||
| registry.close(); | ||
| } catch (Throwable t) { | ||
| // ignore |
There was a problem hiding this comment.
nit: we'd better log the suppressed exception though it will not cause failure
akkinenivijay
pushed a commit
to krisnaru/flink
that referenced
this pull request
Feb 11, 2023
mohsenrezaeithe
pushed a commit
to mohsenrezaeithe/flink
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
We should shut down the executors when failed to creating the Executor. Shut down the ExecutorService can releases used system resources.