Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-1.16][FLINK-30878][runtime] Revert "[FLINK-30474][runtime] Propagates leader information change only if the leadership is still acquired" #21831

Merged
merged 1 commit into from Feb 2, 2023

Conversation

XComp
Copy link
Contributor

@XComp XComp commented Feb 2, 2023

This reverts commit edaa148. The correlated PR on master is #21830.

What is the purpose of the change

See FLINK-30878 for analysis. PR #21819 caused this.

Brief change log

Reverting the FLINK-30474 change.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented?not applicable

…er information change only if the leadership is still acquired"

This reverts commit edaa148.
@XComp XComp changed the title [FLINK-30878][runtime] Revert "[FLINK-30474][runtime] Propagates leader information change only if the leadership is still acquired" [BP-1.16][FLINK-30878][runtime] Revert "[FLINK-30474][runtime] Propagates leader information change only if the leadership is still acquired" Feb 2, 2023
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 2, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@XComp
Copy link
Contributor Author

XComp commented Feb 2, 2023

The correlated master PR #21830 is approved. I'm not going to wait for the CI to be green because it's a plain git revert without conflicts and it's stabilizing release-1.16 again.

@XComp XComp merged commit 3366c1f into apache:release-1.16 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants