Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-1.16][FLINK-30881][ci] Replaces optional minikube installation by mandatory removal #21836

Merged
merged 1 commit into from Feb 3, 2023

Conversation

XComp
Copy link
Contributor

@XComp XComp commented Feb 2, 2023

1.16 backport PR of parent PR #21834

What is the purpose of the change

The goal is to fix the Minikube version instead of relying on the Minikube version that's provided by the AzureCI Docker image.

Brief change log

  • Removes any minikube version that's not matching the required version
  • Installs the expected minikube version

Verifying this change

  • Normal ci run with k8s tests should pass

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

…y removal

The goal of this change is to have a fixed Minikube version.

Signed-off-by: Matthias Pohl <matthias.pohl@aiven.io>
@XComp XComp changed the title [FLINK-30881][ci] Replaces optional minikube installation by mandatory removal [BP-1.16][FLINK-30881][ci] Replaces optional minikube installation by mandatory removal Feb 2, 2023
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 2, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@XComp
Copy link
Contributor Author

XComp commented Feb 3, 2023

@wangyang0918 approved this approach in the 1.15 backport PR #21837

@XComp XComp merged commit e13a73f into apache:release-1.16 Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants