Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-30817] Fix ClassCastException in TestValuesTableFactory #21878

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shuiqiangchen
Copy link
Contributor

What is the purpose of the change

  • Fix the wrong class cast in TestValuesTableFactory.TestValuesScanTableSourceWithoutProjectionPushDown*

Brief change log

  • Changed the value of remainingPartitions to Collections.emptyList()

Verifying this change

This change is a simple bug fix without test case covered.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? ( no )
  • If yes, how is the feature documented? (not documented)

@shuiqiangchen
Copy link
Contributor Author

shuiqiangchen commented Feb 7, 2023

Hi, @luoyuxia Could you please help review the PR. This PR is a simple bug fix, so currently there is no test case for it. If it's necessary, I will add one. What do you think?

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 7, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@luoyuxia
Copy link
Contributor

luoyuxia commented Feb 7, 2023

cc @xuyangzhong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants