Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-30629][test] Set CLIENT_ALIVENESS_CHECK_DURATION to clientHeartbeatInterval for testJobCancelledIfClientHeartbeatTimeout #21916

Closed
wants to merge 1 commit into from

Conversation

reswqa
Copy link
Member

@reswqa reswqa commented Feb 13, 2023

What is the purpose of the change

ClientHeartbeatTest#testJobCancelledIfClientHeartbeatTimeout gave an inappropriate timeout value(1s), which will make it very unstable. In fact, we might want to do is setting the CLIENT_ALIVENESS_CHECK_DURATION to ClientHeartbeatTest.clientHeartbeatInterval instead which leads to the job being cancelled after 550ms (500ms + 50ms) in the worst case which makes the 1 second wait time within the test more reasonable again.

Brief change log

  • Set CLIENT_ALIVENESS_CHECK_DURATION to clientHeartbeatInterval for testJobCancelledIfClientHeartbeatTimeout.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@reswqa reswqa requested a review from XComp February 13, 2023 09:54
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 13, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@reswqa reswqa changed the title [FLINK-30629][test] Let testJobCancelledIfClientHeartbeatTimeout rely on global timeout [FLINK-30629][test] Set CLIENT_ALIVENESS_CHECK_DURATION to clientHeartbeatInterval for testJobCancelledIfClientHeartbeatTimeout Feb 14, 2023
Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I could reproduce the error and that the fix works locally by adding a +1 to the interval to make it more likely for the test to fail even locally.

May you create 1.17 backport PR.

@reswqa
Copy link
Member Author

reswqa commented Feb 14, 2023

BP-1.17 pull request(#21929) created.

I also force-pushed the commit in this pr to fix incorrect commit message.

…tbeatInterval for ClientHeartbeatTest#testJobCancelledIfClientHeartbeatTimeout.
@reswqa
Copy link
Member Author

reswqa commented Feb 15, 2023

CI is green, merged.

@reswqa reswqa closed this in bf0ad52 Feb 15, 2023
mohsenrezaeithe pushed a commit to mohsenrezaeithe/flink that referenced this pull request Feb 21, 2023
…tbeatInterval for ClientHeartbeatTest#testJobCancelledIfClientHeartbeatTimeout.

This closes apache#21916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants