Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-31132] Compact without setting parallelism does not follow the configured sink parallelism for HiveTableSink #21977

Closed
wants to merge 3 commits into from
Closed

[FLINK-31132] Compact without setting parallelism does not follow the configured sink parallelism for HiveTableSink #21977

wants to merge 3 commits into from

Conversation

reswqa
Copy link
Member

@reswqa reswqa commented Feb 20, 2023

What is the purpose of the change

If the parallelism of compact operator was not set, it should use the sink parallelism and disable parallelism inference when using adaptive batch scheduler to avoid take much time to finish compaction.

Brief change log

  • Expose StreamNode#isParallelismConfigured for testing.
  • Let hive compact operator without setting parallelism subject to sink operator's configured parallelism.

Verifying this change

This change added test HiveTableCompactSinkTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 20, 2023 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

luoyuxia
luoyuxia reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reswqa Thanks for fixing. I left some comments. PTAL.

...ink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/BatchSink.java Outdated Show resolved Hide resolved
...ink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/BatchSink.java Outdated Show resolved Hide resolved
...ctors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java Outdated Show resolved Hide resolved
...onnector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableCompactSinkITCase.java Show resolved Hide resolved
...flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSinkITCase.java Outdated Show resolved Hide resolved
...-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableCompactSinkTest.java Outdated Show resolved Hide resolved
JunRuiLee
JunRuiLee reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@JunRuiLee JunRuiLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reswqa Thanks for creating this pr, I just have a little comment, please take a look.

...-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableCompactSinkTest.java Outdated Show resolved Hide resolved
@reswqa
Copy link
Member Author

reswqa commented Feb 21, 2023

Thanks @luoyuxia and @JunRuiLee for the review, I have updated this pr in two fixup commits, PTAL agian~

luoyuxia
luoyuxia reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reswqa Thanks for updating. I only left minor comments. PTAL.

...-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableCompactSinkTest.java Outdated Show resolved Hide resolved
...-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableCompactSinkTest.java Outdated Show resolved Hide resolved
...-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableCompactSinkTest.java Outdated Show resolved Hide resolved
@reswqa
Copy link
Member Author

reswqa commented Feb 21, 2023 •
edited

I have updated this according to your comments, @luoyuxia would you mind taking a look again?

luoyuxia
luoyuxia approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reswqa Thanks for updating. LGTM

JunRuiLee
JunRuiLee reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@JunRuiLee JunRuiLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reswqa Thanks for update and most of it looks good except for one small place, I left a small comment. PTAL

flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamNode.java Outdated Show resolved Hide resolved
JunRuiLee
JunRuiLee approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@JunRuiLee JunRuiLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reswqa Thanks for updating. LGTM

@reswqa
[hotfix][test] Migrate HiveTableCompactSinkTICase, HiveTableFactoryTe…
29e20ae 
…st, HiveTableSinkITCase to Junit5 and AssertJ.
@reswqa
[FLINK-31132][hive] Let hive compact operator without setting paralle…
d0cbeca 
…lism subject to sink operator's configured parallelism.
@reswqa reswqa closed this in 2e91543 Feb 22, 2023
Samrat002 pushed a commit to Samrat002/flink that referenced this pull request Feb 23, 2023
@reswqa @Samrat002
[FLINK-31132][hive] Let hive compact operator without setting paralle…
14373ab 
…lism subject to sink operator's configured parallelism.

This closes apache#21977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luoyuxia luoyuxia luoyuxia approved these changes

@JunRuiLee JunRuiLee JunRuiLee approved these changes

Assignees
No one assigned
Labels
component=Connectors/Hive component=TableSQL/Planner
Projects
None yet
Milestone
No milestone
4 participants
@reswqa @flinkbot @luoyuxia @JunRuiLee