Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-31262][kafka] Move kafka sql connector fat jar test to SmokeKafkaITCase #22060

Closed
wants to merge 4 commits into from

Conversation

reswqa
Copy link
Member

@reswqa reswqa commented Mar 1, 2023

What is the purpose of the change

SmokeKafkaITCase only covered the application packaging test of datastream job, we should also bring this kind of test to sql job submitted by sql-client to cover the case of sql connector fat jar.
In fact, we already have similar test class with the same purpose, that is SQLClientKafkaITCase, but this test is ignored since 2021/4/20. It depend on the
LocalStandaoneKafkaResource which download kafka and sets up a local cluster, but we often encounter download failures in CI environments. Fortunately, now we prefer to use TestContainer in E2E test. So I suggest integrating the corresponding test logic into SmokeKafkaITCase, and then removing it

Brief change log

  • Remove flink-streaming-kafka-test-base module.
  • Remove SQLClientKafkaITCase.
  • Add sql smoke test for kafka.

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 1, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@davidradl
Copy link

I see #22797 , this pr is no longer relevant to this repository, I suggest closing this pr and porting the change to the new Flink connector kafka repo if it is still relevant.

@reswqa
Copy link
Member Author

reswqa commented Oct 9, 2023

Yes, I will close this.

@reswqa reswqa closed this Oct 9, 2023
@MartijnVisser
Copy link
Contributor

@reswqa Will you move it to the other repo?

@reswqa
Copy link
Member Author

reswqa commented Oct 16, 2023

Yes, but it may take some long time. I have been busy with other things recently. Before that, anyone interested can take over this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants