Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-31501][FLINK-31512][table] Move SqlCreateView/SqlAlterView conversion logic to converters #22211

Closed
wants to merge 2 commits into from

Conversation

wuchong
Copy link
Member

@wuchong wuchong commented Mar 19, 2023

What is the purpose of the change

Move the conversion logic of SqlCreateView and SqlAlterView from SqlNodeToOperationConversion to converters.

Brief change log

  • Introduce SqlCreateViewConverter and move the conversion logic of SqlCreateView -> CreateViewOperation to it.
  • Introduce SqlAlterView**Converter and move the conversion logic of SqlAlterView** -> AlterView**Operation to it.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 19, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuchong for the refactor, LGTM

@wuchong wuchong deleted the SqlCreateView branch March 24, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants