Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-31531][hive] Fix HiveCatalogHiveMetadataTest&HiveDialectITCase failure in Hive3 #22230

Merged
merged 2 commits into from Mar 22, 2023

Conversation

luoyuxia
Copy link
Contributor

@luoyuxia luoyuxia commented Mar 21, 2023

What is the purpose of the change

To fix HiveCatalogHiveMetadataTest#testCreateTableWithConstraints failure in Hive3

Brief change log

Change the datatype of z in testCreateTableWithConstraints to nullable,

Verifying this change

Sucessful build for flink-connector-hive with Hive3.
The test failure is related to FLINK-29618

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 21, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luoyuxia for the quick fix, LGTM

@luoyuxia
Copy link
Contributor Author

@flinkbot run azure

1 similar comment
@luoyuxia
Copy link
Contributor Author

@flinkbot run azure

@luoyuxia luoyuxia changed the title [FLINK-31531][hive] Fix HiveCatalogHiveMetadataTest failure in Hive3 [FLINK-31531][hive] Fix HiveCatalogHiveMetadataTest&HiveDialectITCase failure in Hive3 Mar 22, 2023
@luoyuxia luoyuxia merged commit e342f12 into apache:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants