Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-31424][table-planner] Fix NPE produced by multiple sink with local-global window aggregate #22238

Merged
merged 1 commit into from Mar 23, 2023

Conversation

LadyForest
Copy link
Contributor

What is the purpose of the change

This fix is a cherry-pick from #22222

Brief change log

  • Let FlinkRelMdWindowProperties support computing window properties for StreamPhysicalGlobalWindowAggregate.

Verifying this change

This change added tests and can be verified as follows:

  • Add FlinkRelMdWindowPropertiesTest to verify the window properties computation on different rel nodes.
  • Add test under WindowJoinTest to verify the case.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

…ocal-global window aggregate

This closes apache#22222

(cherry picked from commit 824259e)
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 22, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@lincoln-lil lincoln-lil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lincoln-lil lincoln-lil merged commit 71f2306 into apache:release-1.17 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants