[FLINK-31545][jdbc-driver] Create executor in flink connection #22289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FangYongs
force-pushed
the
FLINK-31545_connection_create_executor
branch
2 times, most recently
from
bdc83df
to
da78097
Compare
libenchao
reviewed
Mar 31, 2023
There was a problem hiding this comment.
@FangYongs Thanks for your contribution, I've left my comments.
...k-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkConnection.java
Show resolved
Hide resolved
...k-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkConnection.java
Show resolved
Hide resolved
...ble/flink-sql-jdbc-driver/src/test/java/org/apache/flink/table/jdbc/FlinkConnectionTest.java
Show resolved
Hide resolved
FangYongs
force-pushed
the
FLINK-31545_connection_create_executor
branch
from
da78097
to
20641fa
Compare
|
Thanks @libenchao , I have rebased master and updated this PR |
libenchao
reviewed
Apr 3, 2023
There was a problem hiding this comment.
@FangYongs Thanks for the updating, it looks good to me. I only left one nit comment.
|
|
||
| public FlinkConnection(DriverUri driverUri) { | ||
| this.driverUri = driverUri; | ||
| // TODO Support default context from map to get gid of flink core for jdbc driver |
There was a problem hiding this comment.
It would be great if you also add the JIra link in the comment.
There was a problem hiding this comment.
Thanks @libenchao , added the jira link
|
CI now fails due to the API compatibility problem, could you fix that. |
libenchao
approved these changes
Apr 4, 2023
xiangyuf
pushed a commit
to xiangyuf/flink
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR aims to create
ExecutorinFlinkConnectionand supports catalog/schema related operationsBrief change log
ExecutorinFlinkConnectionFlinkConnectionVerifying this change
This change added tests and can be verified as follows:
testCatalogSchemaandtestClientInfoinFlinkConnectionTestDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no) noDocumentation