[FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…

[xiaochen-zhou]

What is the purpose of the change

Upgrade the deprecated UniqueConstraint to the new one

Brief change log

• Upgrade the deprecated UniqueConstraint to the new one

Verifying this change

This change is already covered by existing tests, such as UniqueConstraintTest.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no )
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)

[flinkbot]

CI report:

• 57fa727 UNKNOWN
• d1f214c Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[xiaochen-zhou]

can you spare some precious time to review? Thanks very much @Aitozi @wuchong

[Aitozi]

@clownxc Thanks for your work. I just left one minor comments.

BTW, the CI failed.

[Aitozi]

I'm afraid we can't directly remove this @PublicEvolving API. CC @luoyuxia

[luoyuxia]

+1. Share same concern. We must be cautious about dropping @PublicEvolving api.

[xiaochen-zhou]

+1. Share same concern. We must be cautious about dropping @PublicEvolving api.

Thank you so much for review. I will rollback '@ PublicEvolving' api Delete operation @luoyuxia @Aitozi

[xiaochen-zhou]

@clownxc Thanks for your work. I just left one minor comments.

BTW, the CI failed.

Thank you so much for review. The reason for the CI failure is “You have 1 Checkstyle violation”. I will modify the code style to comply with Flink‘s rewuirements

[Aitozi]

Why this changed ?

[xiaochen-zhou]

there are some minor differences between the new and old APIs

public final String asSummaryString() {
        return String.format(
                "CONSTRAINT %s %s (%s)%s",
                EncodingUtils.escapeIdentifier(getName()),
                getTypeString(),
                columns.stream()
                        .map(EncodingUtils::escapeIdentifier)
                        .collect(Collectors.joining(", ")),
                isEnforced() ? "" : " NOT ENFORCED");
  }

The method escapeIdentifier of the new api adds a symbol `` to each field

    public static String escapeIdentifier(String s) {
        return "`" + escapeBackticks(s) + "`";
    }

@Aitozi

[xiaochen-zhou]

this is the deprecated UniqueConstraint

    public final String asSummaryString() {
        final String typeString;
        switch (getType()) {
            case PRIMARY_KEY:
                typeString = "PRIMARY KEY";
                break;
            case UNIQUE_KEY:
                typeString = "UNIQUE";
                break;
            default:
                throw new IllegalStateException("Unknown key type: " + getType());
        }

        return String.format(
                "CONSTRAINT %s %s (%s)", getName(), typeString, String.join(", ", columns));
    }

[Aitozi]

LGTM +1

[xiaochen-zhou]

I applied the suggested code changes.Can you please do another review @luoyuxia

[luoyuxia]

@clownxc Thanks for contribution. I'll have a look when i'm free