[FLINK-31471] Allow setting JobResourceRequirements through WEB UI. #22350
Conversation
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java
Show resolved
Hide resolved
|
Thanks for the review Chesnay, I've addressed the comments and scheduled some follow-ups. PTAL |
There was a problem hiding this comment.
There are some usability issues here:
- errors about exceeding max parallelism are not reported to the user or handled by the UI
- Scale column should be closer to the
parallelismcolumn since it modifies that - +1/-1 buttons are neat for demos, but annoying if you go even beyond a few slots
3.a) Maybe the parallelism column could be changed to a textbox where a user can enter a parallelism - Until a restart we show the user-configured target parallelism in the
parallelismcolumn, but after a restart this is gone and goes back to the actual parallelism.
|
For the UX comments: I'm not a UX person, and this is good enough for the demo purpose (it was not meant for serious usage, that's what REST API is for). We touched on this a few weeks back with @knaufk, and the plan is to reach out to the ML with the demo and see if any UX-proficient person volunteers to improve this. WDYT? I can, of course, try to pull something off, but there is certainly a limit on how good I can make this.
👍 I'll look into that. |
That plan sounds fine to me. Let's file tickets for the issues I've listed. |
|
@zentol The error handling is now fixed if you want to try it out.
|
yeah, it's not optimal 😢 that's a different issue to address though |
| @@ -96,13 +105,19 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura | |||
|
|
|||
| final boolean webSubmitEnabled = configuration.getBoolean(WebOptions.SUBMIT_ENABLE); | |||
| final boolean webCancelEnabled = configuration.getBoolean(WebOptions.CANCEL_ENABLE); | |||
| final boolean webRescaleSupported = | |||
| ClusterOptions.isAdaptiveSchedulerEnabled(configuration) | |||
| && !ClusterOptions.isReactiveModeEnabled(configuration); | |||
There was a problem hiding this comment.
Why cannot change the parallelism of a job running in reactive mode
https://issues.apache.org/jira/browse/FLINK-31471