Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-31868] Fix DefaultInputSplitAssigner javadoc for class #22437

Closed
wants to merge 1 commit into from

Conversation

pvary
Copy link
Contributor

@pvary pvary commented Apr 20, 2023

What is the purpose of the change

Fix the discrepancy between the code and the comment. The comment erroneously states that the return order for the splits is in order.

Brief change log

The decision was to update the comment

Verifying this change

No testing is needed

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? JavaDocs

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 20, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR! @pvary
LGTM.

@zhuzhurk zhuzhurk closed this in f240a51 Apr 21, 2023
@pvary
Copy link
Contributor Author

pvary commented Apr 21, 2023

Thanks @zhuzhurk for the guidance and commit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants