[FLINK-31876][QS] Migrate flink-queryable-state-runtime tests to JUnit5 #22457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredia
force-pushed
the
FLINK-31876-runtime
branch
2 times, most recently
from
21aefe1
to
eb85a9b
Compare
masteryhx
requested changes
Apr 25, 2023
...ueryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
Outdated
Show resolved
Hide resolved
...me/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
Show resolved
Hide resolved
...me/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
Outdated
Show resolved
Hide resolved
fredia
force-pushed
the
FLINK-31876-runtime
branch
2 times, most recently
from
203b934
to
3e5d7f9
Compare
|
@reswqa could you please help take a look? |
reswqa
reviewed
May 6, 2023
...e/src/test/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyImplTest.java
Outdated
Show resolved
Hide resolved
...me/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
Outdated
Show resolved
Hide resolved
...me/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
Outdated
Show resolved
Hide resolved
...me/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
Outdated
Show resolved
Hide resolved
...me/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
Outdated
Show resolved
Hide resolved
...-runtime/src/test/java/org/apache/flink/queryablestate/network/KvStateClientHandlerTest.java
Outdated
Show resolved
Hide resolved
...time/src/test/java/org/apache/flink/queryablestate/network/KvStateRequestSerializerTest.java
Outdated
Show resolved
Hide resolved
...-runtime/src/test/java/org/apache/flink/queryablestate/network/KvStateServerHandlerTest.java
Outdated
Show resolved
Hide resolved
...-runtime/src/test/java/org/apache/flink/queryablestate/network/KvStateServerHandlerTest.java
Outdated
Show resolved
Hide resolved
...e-state-runtime/src/test/java/org/apache/flink/queryablestate/network/KvStateServerTest.java
Outdated
Show resolved
Hide resolved
reswqa
approved these changes
May 9, 2023
fredia
force-pushed
the
FLINK-31876-runtime
branch
from
8c4b9dd
to
f563e7d
Compare
|
@reswqa Thanks for the review and suggestions, squashed. |
|
@flinkbot run azure |
|
@reswqa CI turns green, but the result is not synchronized to flinkbot, could you help merge it? thanks. https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=48819&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Migrate flink-queryable-state-runtime tests to JUnit5