Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-31880][tests] Fixes unit test so it will pass regardless of ti… #22586

Closed
wants to merge 1 commit into from
Closed

Conversation

kurtostfeld
Copy link

Fixes unit test so it will pass regardless of time zone it is run in. Also use a better testing date.

I submitted this before, I'm resubmitting with issues fixed. This should follow commit and PR style guides.

This is a low priority issue, as the Flink projects only needs unit tests to pass in the CI system, not in other environments in other time zones, but it's helpful to some developers to have this pass, this is very low risk, and this also uses a better test value. The previous code uses new Date(562423) which is 9 minutes after the epoch in UTC, and in UTC-5 time zone it's before the epoch of 1970-01-01, and that's a poor test value.

…me zone it is run in. Also use a better testing date.
@flinkbot
Copy link
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@kurtostfeld
Copy link
Author

@MartijnVisser Can this get merged or should I discard? It's a low priority but low risk small fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants