Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-31354][tests] Increased timeout for NettyClientServerSslTest to improve test stability #22591

Merged
merged 1 commit into from May 22, 2023

Conversation

XComp
Copy link
Contributor

@XComp XComp commented May 16, 2023

What is the purpose of the change

We see the test occassionally fail due to slow CI machines (see further details in FLINK-31354). Increasing the timeouts should solve the issue.

Brief change log

  • Increased the timeouts from 1s to 5s

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@XComp XComp requested a review from zentol May 16, 2023 08:36
@XComp
Copy link
Contributor Author

XComp commented May 16, 2023

@zentol I guess, increasing the timeout should not cause any problems?! The test usually runs in milliseconds but occasionally runs into the 1000ms limit.

@flinkbot
Copy link
Collaborator

flinkbot commented May 16, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@dmvk
Copy link
Member

dmvk commented May 18, 2023

The test usually runs in milliseconds but occasionally runs into the 1000ms limit.

Can we simply increase the timeouts to a really high number (~ 1h-ish)?

…o improve test stability

Signed-off-by: Matthias Pohl <matthias.pohl@aiven.io>
@XComp
Copy link
Contributor Author

XComp commented May 22, 2023

Yeah, we could do that. It doesn't do much of a difference to the test. The test sets up the Netty context and verifies that timeout config values are forwarded correctly. I changed the test slightly to serve different values rather than relying on the same value to improve the test case

Copy link
Member

@dmvk dmvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants