[FLINK-32142][build][flink-runtime-web] Upgrade frontend-maven-plugin...

[elphastori]

… to 1.12.1

What is the purpose of the change

This pull request fixes the build for Apple Silicon which breaks while attempting to run nodejs for flink-runtime-web. The issue is explained in https://issues.apache.org/jira/browse/FLINK-32142

Brief change log

• Upgrades frontend-maven-plugin from version 1.11.0 to the latest version, 1.12.1.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable)

[flinkbot]

CI report:

• 44a185b Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[reswqa]

Thanks @elphastori for the contribution! I also encountered the same problem on my M1 macbook. I used -Dskip.npm to skip this every time I compiled, and I will try to see if this fixes my problem also. 😆

[reswqa]

@yangjunhan Would you mind taking a look at this? I'm not sure if there will be any other concern with this upgrade.

[elphastori]

Thanks @elphastori for the contribution! I also encountered the same problem on my M1 macbook. I used -Dskip.npm to skip this every time I compiled, and I will try to see if this fixes my problem also. 😆

Great! I'll start using -Dskip.npm workaround in the meantime too.

[elphastori]

@reswqa @yanchenyun Could you please take a last look at the PR?

[hlteoh37]

@elphastori Thanks for the contribution - have we done any form of validation in the final artifact produced to verify the plugin works the same way in the new version?

Overall seems ok. The changelog is small (https://github.com/eirslett/frontend-maven-plugin/blob/master/CHANGELOG.md). Also interestingly it suggest 1.11.0 supports apple silicon

[elphastori]

have we done any form of validation in the final artifact produced to verify the plugin works the same way in the new version?
Yes. The build produces Flink dashboard assets which are identical to the previous plugin version