Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-32198][runtime] Enforce single maxExceptions query parameter #22663

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-32198][runtime] Enforce single maxExceptions query parameter #22663

wants to merge 1 commit into from

Conversation

pgaref
Copy link
Contributor

@pgaref pgaref commented May 26, 2023

https://issues.apache.org/jira/browse/FLINK-32198

  • throw ConversionException when multiple values are passed for maxExceptions parameter
  • added test to validate functionality

@flinkbot
Copy link
Collaborator

flinkbot commented May 26, 2023 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

zentol
zentol requested changes May 26, 2023
View reviewed changes
Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an api-breaking change and can't be merged.

@pgaref
Copy link
Contributor Author

pgaref commented May 26, 2023 •
edited

This is an api-breaking change and can't be merged.

Thanks for taking a look @zentol !
Whats the policy for making such changes?

@zentol zentol self-assigned this May 30, 2023
@zentol
Copy link
Contributor

zentol commented May 30, 2023 •
edited

Whats the policy for making such changes?

The policy is that we can't make the change until Flink 2.0, unless the benefits are exceptional (which in this case they aren't really).

@pgaref pgaref requested a review from zentol December 7, 2023 02:28
@pgaref
Copy link
Contributor Author

pgaref commented Dec 7, 2023

Hey @zentol -- are we currently allowing changes as part of Flink 2.0? Would it make sense pushing this fix?

@zentol zentol removed their assignment Mar 4, 2024
@pgaref
[FLINK-32198][runtime] Enforce single maxExceptions query parameter
815c5bc 
* throw ConversionException when multiple values are passed for maxExceptions parameter
* added test to validate functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zentol zentol Awaiting requested review from zentol

Assignees
No one assigned
Labels
component=Runtime/REST
Projects
None yet
Milestone
No milestone
3 participants
@pgaref @flinkbot @zentol