[FLINK-32329][tests] Do not override env.java.opts.all #22774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XComp
changed the title
XComp
reviewed
Jun 13, 2023
XComp
approved these changes
Jun 14, 2023
|
One more thing here: What about using the long version of the parameter instead of the short version for readability purposes? nit: The current commit message has a wrong Jira issue ID |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env.java.opts.all will soon become very important because it contains the Java 17 module declarations. Tests thus shouldn't just override this value.
(In the future we could add a utility bash method to append a value to an existing option)