[FLINK-32332][sql-gateway] Show jars being used by function #22777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fsk119 , could you help to review this PR when you are free? thanks |
FangYongs
changed the title
FangYongs
force-pushed
the
FLINK_32332_show_jar_files
branch
from
3982885
to
e664ed9
Compare
fsk119
reviewed
Jun 19, 2023
| functionCatalog.getUserDefinedFunctions( | ||
| catalogManager.getCurrentCatalog(), catalogManager.getCurrentDatabase()); | ||
| Catalog catalog = catalogManager.getCatalog(catalogManager.getCurrentCatalog()).get(); | ||
| for (FunctionIdentifier identifier : identifiers) { |
There was a problem hiding this comment.
It seems it's a little heavy to check the catalog function one by one. I think it's better we register the resource URL into the ResourceManager. But I think we can leave this to the future work.
Comment on lines
+189
to
+194
| if (jars.contains(jarPath)) { | ||
| throw new UnsupportedOperationException( | ||
| String.format( | ||
| "Can not delete jar file [%s] while it is being used by function.", | ||
| jarPath)); | ||
| } |
There was a problem hiding this comment.
The jar list that is returned by the SHOW JAR syntax also contains the connector jars. It's a little hard to check if the jar is a connector jar or a function jar. If it is a connector jar, I think we can not check whether we have instances using this jar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Currently
show jarsstatement will not show the jars added by a function when the function is never used by a job in gateway, this PR aims to fixed it.Brief change log
ShowJarsOperationVerifying this change
This change added tests and can be verified as follows:
function.qtoshow jarsbefore and after a function is used.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no) noDocumentation