[FLINK-32345][state] Improve parallel download of RocksDB incremental state. #22788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flinkbot run azure |
StefanRRichter
force-pushed
the
srichter-FLINK-32345-parallel-download
branch
2 times, most recently
from
7553cf6
to
a10fcd4
Compare
|
@flinkbot run azure |
This commit improves RocksDBStateDownloader to support parallelized state download across multiple state types and across multiple state handles. This can improve our download times for scale-in.
StefanRRichter
force-pushed
the
srichter-FLINK-32345-parallel-download
branch
from
a10fcd4
to
e697f77
Compare
|
@flinkbot run azure |
...ava/org/apache/flink/contrib/streaming/state/restore/RocksDBIncrementalRestoreOperation.java
Outdated
Show resolved
Hide resolved
| StateHandleDownloadSpec downloadRequest = | ||
| new StateHandleDownloadSpec( | ||
| (IncrementalRemoteKeyedStateHandle) stateHandle, | ||
| absolutInstanceBasePath.resolve(UUID.randomUUID().toString())); |
There was a problem hiding this comment.
FYI, @zoltar9264 is changing how the local path is derived in #22669.
...ava/org/apache/flink/contrib/streaming/state/restore/RocksDBIncrementalRestoreOperation.java
Outdated
Show resolved
Hide resolved
...d-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateDownloader.java
Outdated
Show resolved
Hide resolved
...d-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateDownloader.java
Outdated
Show resolved
Hide resolved
...d-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateDownloader.java
Outdated
Show resolved
Hide resolved
Comment on lines
+122
to
+137
| entry -> { | ||
| StateHandleID stateHandleID = entry.getKey(); | ||
| StreamStateHandle remoteFileHandle = | ||
| entry.getValue(); | ||
| Path downloadDest = | ||
| downloadRequest | ||
| .getDownloadDestination() | ||
| .resolve( | ||
| stateHandleID | ||
| .toString()); | ||
| return ThrowingRunnable.unchecked( | ||
| () -> | ||
| downloadDataForStateHandle( | ||
| downloadDest, | ||
| remoteFileHandle, | ||
| closeableRegistry)); |
There was a problem hiding this comment.
How about extracting a method createDownloadRunnables(k, v, dst)?
...d-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateDownloader.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/util/CollectionUtil.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/util/CollectionUtil.java
Outdated
Show resolved
Hide resolved
...d-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateDownloader.java
Outdated
Show resolved
Hide resolved
|
@rkhachatryan I addressed all remaining comments, please take another look to approve the PR. |
rkhachatryan
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This commit improves RocksDBStateDownloader to support parallelized state download across multiple state types and across multiple state handles. This can improve our download times for scale-in.
Brief change log
StateHandleDownloadSpecto combine incremental remote handles with their download paths.RocksDBStateDownloaderto accept a list ofStateHandleDownloadSpecthat can combine files from multiple handles and sub-states (shared, private).RocksDBIncrementalRestoreOperationto first assemble a complete list ofStateHandleDownloadSpecbefore invoking the download process.RocksDBStateDownloaderTest.Verifying this change
This change is already covered by existing tests, such as
RocksDBStateDownloaderTest. I added more tests there.EmbeddedRocksDBStateBackendTestEmbeddedRocksDBStateBackendMigrationTestRescalingBenchmarkTestDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation