Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-25872][state/changelog] Hotfix! Fix the description of Changel… #22799

Closed
wants to merge 1 commit into from

Conversation

fredia
Copy link
Contributor

@fredia fredia commented Jun 16, 2023

…ogCompatibilityITCase

What is the purpose of the change

Fix the description of ChangelogCompatibilityITCase, recovering from non-changelog checkpoints in claim mode is supported after FLINK-25872.

Brief change log

  • Fix the description of ChangelogCompatibilityITCase

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 16, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd suggest that rename this commit message to [hotfix][state/changelog] Fix the xxxxx.

@fredia
Copy link
Contributor Author

fredia commented Jun 19, 2023

@reswqa Thanks for the review and suggestion, I amended the commit message as suggested.

@reswqa reswqa closed this in 1ca1980 Jun 19, 2023
Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredia Thanks for the update, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants