Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32386][runtime] Introduce ShuffleDescriptorsCache to cache ShuffleDescriptorAndIndex #22860

Closed
wants to merge 4 commits into from

Conversation

huwh
Copy link
Contributor

@huwh huwh commented Jun 26, 2023

What is the purpose of the change

refer to https://issues.apache.org/jira/browse/FLINK-32386
Introduce ShuffleDescriptorsCache to cache ShuffleDescriptorAndIndex

Brief change log

  • Cache initialized in TaskManagerServices
  • Cache entry will expire after TTL exceed
  • Cache entry will be clear when job disconnected
  • Cache entry has limit control

Verifying this change

This change added tests and can be verified as follows:

  • Added unit tests to verify TTL/job disconnection/size limit

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving):(no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 26, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@wanglijie95
Copy link
Contributor

Hi @huwh, let us move to #22861

@huwh huwh closed this Jul 11, 2023
@huwh huwh deleted the FLINK-32386 branch July 28, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants