Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32465][runtime][security] Fix KerberosLoginProvider.isLoginPossible accidental login with keytab #22887

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

gaborgsomogyi
Copy link
Contributor

What is the purpose of the change

In KerberosLoginProvider.isLoginPossible() there is a call to UserGroupInformation.getCurrentUser() before principal check (keytab usage). This triggers an accidental login with either kerberos credentials if available, or as the local OS user, based on security settings. This is not problematic most of the time since KerberosLoginProvider.doLogin() overwrites the credentials with keytab. The problem hurts however when login in KerberosLoginProvider.isLoginPossible() fails for whatever reason. Such case the workload is just not starting.

Brief change log

Removed accidental login in KerberosLoginProvider.isLoginPossible().

Verifying this change

Added new automated test.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@gaborgsomogyi
Copy link
Contributor Author

cc @gyfora @mbalassi @morhidi

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 28, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@mbalassi mbalassi self-requested a review June 28, 2023 09:50
Copy link
Contributor

@mbalassi mbalassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, isLoginPossible is a deceptive name. 🤦 Let as not forget to backport this to 1.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants