[FLINK-32465][runtime][security] Fix KerberosLoginProvider.isLoginPossible accidental login with keytab #22887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
In
KerberosLoginProvider.isLoginPossible()
there is a call toUserGroupInformation.getCurrentUser()
before principal check (keytab usage). This triggers an accidental login with either kerberos credentials if available, or as the local OS user, based on security settings. This is not problematic most of the time sinceKerberosLoginProvider.doLogin()
overwrites the credentials with keytab. The problem hurts however when login inKerberosLoginProvider.isLoginPossible()
fails for whatever reason. Such case the workload is just not starting.Brief change log
Removed accidental login in
KerberosLoginProvider.isLoginPossible()
.Verifying this change
Added new automated test.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation