Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32422][test] Adds test to cover the issue of forwarding the revoke event immediately to the contender for the EmbeddedLeaderService #22895

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

XComp
Copy link
Contributor

@XComp XComp commented Jun 28, 2023

What is the purpose of the change

I thought about it once more: The revoke leadership event should be immediately handled by the LeaderElectionService because it means that the contender is deregistered and wouldn't be able to handle any outstanding leadership events anymore, anyway. In this way, we have to accept that a revoke event can be sent to the contender twice.

It's implemented in the same way in the DefaultLeaderElectionService (see DefaultLeaderElectionService:233).

Brief change log

  • Added a test to cover the scenario for the EmbeddedLeaderService as well

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

…o test the actual functionality consistently

Signed-off-by: Matthias Pohl <matthias.pohl@aiven.io>
Signed-off-by: Matthias Pohl <matthias.pohl@aiven.io>
…cation handling in case of a close call in the EmbeddedLeaderElection

Signed-off-by: Matthias Pohl <matthias.pohl@aiven.io>
@flinkbot
Copy link
Collaborator

flinkbot commented Jun 28, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants